Conversation
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
91020b3 to
e912397
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
e912397 to
3b4dab9
Compare
|
|
||
| // InstanceActionDetail gives more details on instance action. | ||
| type InstanceActionDetail struct { | ||
| Action string `json:"action"` |
There was a problem hiding this comment.
tried with nested type InstanceAction but the func extractIntoPtr didn't work, So I copy paste all field :/
|
@snigle What's the purpose of this PR? The title has "fix" in it, but no other details. Also, instead of API documentation, can you provide the server-side service code links which prove this implementation is correct? |
|
Build succeeded.
|
|
Sorry I added two missing field in the Get instance actions. (event and
updated At.)
I didn't see these field when I wrote the first version.
Le ven. 14 févr. 2020 à 17:23, theopenlab-ci[bot] <notifications@github.com>
a écrit :
… Build succeeded.
- gophercloud-unittest
<https://logs.openlabtesting.org/logs/51/1851/3b4dab9cea03a60496df51d254d9e82ee14bcec1/check/gophercloud-unittest/e392b06/>
: SUCCESS in 3m 15s
- gophercloud-acceptance-test
<https://logs.openlabtesting.org/logs/51/1851/3b4dab9cea03a60496df51d254d9e82ee14bcec1/check/gophercloud-acceptance-test/94e709c/>
: SUCCESS in 2h 33m 57s
- gophercloud-acceptance-test-ironic
<https://logs.openlabtesting.org/logs/51/1851/3b4dab9cea03a60496df51d254d9e82ee14bcec1/check/gophercloud-acceptance-test-ironic/9523428/>
: SUCCESS in 32m 40s
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1851?email_source=notifications&email_token=AB57VQSTHCVCVPQLHMZXDK3RC3APFA5CNFSM4KVIJI6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELZSSAQ#issuecomment-586361090>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB57VQVUWNSCUXYRXCTTL3DRC3APFANCNFSM4KVIJI6A>
.
|
|
@snigle Thanks. It looks like this set of API calls has a number of features added/modified via microversions. The way that some of these features are implemented in this PR aren't following our current guidelines for microversions. For example, there should be dedicated extract methods for However, I'm currently refactoring things to simplify our guidelines (#1854). Once this is merged, you'll have to make some minor changes, which I'll outline in a review. |
Ok I updated the code as the same way of your PR. |
016a7d6 to
dd9aec2
Compare
|
Build succeeded.
|
|
@snigle Nice - thank you! Everything looks correct. The only remaining item is fixing the Travis errors: https://travis-ci.org/gophercloud/gophercloud/jobs/651404710#L492-L495 Because some fields were changed to pointers, some of the fixtures need modified, too. For example: https://github.com/gophercloud/gophercloud/pull/1851/files#diff-a5d110494cfe4ed97e9f81b89d0e752eR76 var updatedAt = time.Date(2018, 04, 25, 1, 26, 36, 0, time.UTC)
var GetExpected = instanceactions.InstanceActionDetail{
...
UpdatedAt: &updatedAt,
} |
95c9dbb to
c69d192
Compare
Oups .... Forgotten to run test locally :s Fixed now :) |
|
Build succeeded.
|
jtopjian
left a comment
There was a problem hiding this comment.
LGTM - thank you for your work and patience with this one!
For #1845
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://docs.openstack.org/api-ref/compute/?expanded=show-server-action-details-detail,list-actions-for-server-detail#show-server-action-details