Acceptance: add Identity V3 Trusts CRUD test#1645
Closed
ozerovandrei wants to merge 4 commits intogophercloud:masterfrom
Closed
Acceptance: add Identity V3 Trusts CRUD test#1645ozerovandrei wants to merge 4 commits intogophercloud:masterfrom
ozerovandrei wants to merge 4 commits intogophercloud:masterfrom
Conversation
Implement Create and Extract functions for v3/extenstions/trusts package with unit tests and docs. This commit also adds Role struct to this package.
Implement Delete function for the v3/extensions/trusts package with tests and docs.
Add TestTrustCRUD acceptance test with some helpers to create and delete trusts.
|
Build failed.
|
Remove required tag from the "impersonation" argument since it's boolean so we can just don't set "omitempty" tag to always send it in the Create request.
|
Build failed.
|
Contributor
Author
|
There is following error: But I required admin privilegies 🤔: |
Contributor
|
@ozerovandrei It's possible that Identity trusts are not enabled in the OpenLab configuration. @kiwik @huangtianhua Can you confirm if the Keystone/Identity |
Contributor
|
@jtopjian @ozerovandrei I looked the code of keystone, the api 'create_trust' required the rule: RULE_TRUST_OWNER(RULE_TRUST_OWNER = 'user_id:%(trust.trustor_user_id)s') Seems the test you added doesn't follow this rule, could you check this? |
Merged
Contributor
Author
|
Implemented in #1818 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TestTrustCRUD acceptance test with some helpers to create and delete
trusts.
For #1642
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/keystone/blob/stable/stein/keystone/api/trusts.py
https://github.com/openstack/keystone/blob/stable/stein/keystone/trust/core.py