Identity V3: fix Trust Create options

ozerovandrei · ozerovandrei · commit a78fc5c50e88 · 2019-07-15T20:31:20.000+03:00
Remove required tag from the "impersonation" argument since it's boolean
so we can just don't set "omitempty" tag to always send it in the Create
request.
diff --git a/openstack/identity/v3/extensions/trusts/requests.go b/openstack/identity/v3/extensions/trusts/requests.go
@@ -52,7 +52,7 @@ type CreateOptsBuilder interface {
 // CreateOpts provides options used to create a new trust.
 type CreateOpts struct {
 	// Impersonation allows the trustee to impersonate the trustor.
-	Impersonation bool `json:"impersonation" required:"true"`
+	Impersonation bool `json:"impersonation"`
 
 	// TrusteeUserID is a user who is capable of consuming the trust.
 	TrusteeUserID string `json:"trustee_user_id" required:"true"`
diff --git a/openstack/identity/v3/extensions/trusts/testing/fixtures.go b/openstack/identity/v3/extensions/trusts/testing/fixtures.go
@@ -14,7 +14,7 @@ const CreateRequest = `
 {
     "trust": {
         "expires_at": "2019-12-01T14:00:00.999999Z",
-        "impersonation": true,
+        "impersonation": false,
         "allow_redelegation": true,
         "project_id": "9b71012f5a4a4aef9193f1995fe159b2",
         "roles": [
@@ -33,7 +33,7 @@ const CreateResponse = `
     "trust": {
         "expires_at": "2019-12-01T14:00:00.999999Z",
         "id": "3422b7c113894f5d90665e1a79655e23",
-        "impersonation": true,
+        "impersonation": false,
         "redelegation_count": 10,
         "project_id": "9b71012f5a4a4aef9193f1995fe159b2",
         "remaining_uses": null,
diff --git a/openstack/identity/v3/extensions/trusts/testing/requests_test.go b/openstack/identity/v3/extensions/trusts/testing/requests_test.go
@@ -81,7 +81,6 @@ func TestCreateTrust(t *testing.T) {
 	expiresAt := time.Date(2019, 12, 1, 14, 0, 0, 999999999, time.UTC)
 	result, err := trusts.Create(client.ServiceClient(), trusts.CreateOpts{
 		ExpiresAt:         &expiresAt,
-		Impersonation:     true,
 		AllowRedelegation: true,
 		ProjectID:         "9b71012f5a4a4aef9193f1995fe159b2",
 		Roles: []trusts.Role{
@@ -95,7 +94,7 @@ func TestCreateTrust(t *testing.T) {
 	th.AssertNoErr(t, err)
 
 	th.AssertEquals(t, "3422b7c113894f5d90665e1a79655e23", result.ID)
-	th.AssertEquals(t, true, result.Impersonation)
+	th.AssertEquals(t, false, result.Impersonation)
 	th.AssertEquals(t, 10, result.RedelegationCount)
 }
 
