Baremetal Introspection: Move hostname to InventoryType#1627
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Jun 17, 2019
Merged
Baremetal Introspection: Move hostname to InventoryType#1627jtopjian merged 1 commit intogophercloud:masterfrom
jtopjian merged 1 commit intogophercloud:masterfrom
Conversation
Contributor
|
@bcrochet Given how this was initially placed incorrectly, can you add a unit test to ensure it's correct? Please either use actual API output from a real query or base a fixture on a real query. |
|
Build failed.
|
The IPA patch added the hostname to the Inventory field, not as a top-level field. This moves the hostname into the InventoryType where it belongs.
1b889ed to
a626d7b
Compare
|
Build succeeded.
|
zaneb
added a commit
to zaneb/baremetal-operator
that referenced
this pull request
Jun 17, 2019
This pulls in the fix for hostname support gophercloud/gophercloud#1627 Signed-off-by: Zane Bitter <zbitter@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IPA patch added the hostname to the Inventory field, not as a top-level
field. This moves the hostname into the InventoryType where it belongs.
For #1626