Baremetal Inspector noauth support#1531
Merged
ozerovandrei merged 1 commit intogophercloud:masterfrom Apr 17, 2019
Merged
Conversation
1 similar comment
|
Build succeeded.
|
Contributor
|
This looks good to me, though I have no way of verifying it first-hand. If it works for you, I'm happy to merge this. |
zaneb
added a commit
to zaneb/baremetal-operator
that referenced
this pull request
Apr 2, 2019
Due to support for noauth baremetalintrospection equivalent to that for noauth baremetal not yet existing in gophercloud, just set up the client here. Once support merges in gophercloud (gophercloud/gophercloud#1531) and we have updated the vendored version, we can switch to using that. Signed-off-by: Zane Bitter <zbitter@redhat.com>
zaneb
added a commit
to zaneb/baremetal-operator
that referenced
this pull request
Apr 10, 2019
Due to support for noauth baremetalintrospection equivalent to that for noauth baremetal not yet existing in gophercloud, just set up the client here. Once support merges in gophercloud (gophercloud/gophercloud#1531) and we have updated the vendored version, we can switch to using that. Signed-off-by: Zane Bitter <zbitter@redhat.com>
For gophercloud#1485 Add noauth support for the baremetal introspection (ironic-inspector) service. Signed-off-by: Zane Bitter <zbitter@redhat.com>
zaneb
added a commit
to zaneb/baremetal-operator
that referenced
this pull request
Apr 12, 2019
Due to support for noauth baremetalintrospection equivalent to that for noauth baremetal not yet existing in gophercloud, just set up the client here. Once support merges in gophercloud (gophercloud/gophercloud#1531) and we have updated the vendored version, we can switch to using that. Signed-off-by: Zane Bitter <zbitter@redhat.com>
zaneb
added a commit
to zaneb/baremetal-operator
that referenced
this pull request
Apr 17, 2019
Due to support for noauth baremetalintrospection equivalent to that for noauth baremetal not yet existing in gophercloud, just set up the client here. Once support merges in gophercloud (gophercloud/gophercloud#1531) and we have updated the vendored version, we can switch to using that. Signed-off-by: Zane Bitter <zbitter@redhat.com>
59ec820 to
b3ceae1
Compare
Contributor
Author
|
Fixed an inconsistency between the docs and the code. I can confirm that this is working for me. |
zaneb
added a commit
to zaneb/baremetal-operator
that referenced
this pull request
Apr 17, 2019
Due to support for noauth baremetalintrospection equivalent to that for noauth baremetal not yet existing in gophercloud, just set up the client here. Once support merges in gophercloud (gophercloud/gophercloud#1531) and we have updated the vendored version, we can switch to using that. Signed-off-by: Zane Bitter <zbitter@redhat.com>
|
Build succeeded.
|
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1485
Add noauth support for the baremetal introspection (ironic-inspector)
service.
This is heavily based on the equivalent noauth support already present for the main Ironic API.
Source reference:
https://github.com/openstack/ironic-inspector/tree/master/ironic_inspector