LBaaSv2 / Octavia: Add client and member data timeouts#1394
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Jan 10, 2019
Merged
LBaaSv2 / Octavia: Add client and member data timeouts#1394jtopjian merged 1 commit intogophercloud:masterfrom
jtopjian merged 1 commit intogophercloud:masterfrom
Conversation
emonty
added a commit
to emonty/cloud-provider-openstack
that referenced
this pull request
Jan 9, 2019
The octavia loadbalancer supports setting timeouts for client and member data connections. For some operations, such as pushing git large git repositories over an ssh connection, it is very important to be able to increase the timeout. This adds two annotations that allows a user to create a load balancer and set its timeout_client_data and timeout_member_data fields. Depends-On: gophercloud/gophercloud#1394 Signed-off-by: Monty Taylor <mordred@inaugust.com>
|
Build failed.
|
7174d89 to
cc43da5
Compare
emonty
added a commit
to emonty/cloud-provider-openstack
that referenced
this pull request
Jan 10, 2019
The octavia loadbalancer supports setting timeouts for client and member data connections. For some operations, such as pushing git large git repositories over an ssh connection, it is very important to be able to increase the timeout. This adds two annotations that allows a user to create a load balancer and set its timeout_client_data and timeout_member_data fields. Depends-On: gophercloud/gophercloud#1394 Signed-off-by: Monty Taylor <mordred@inaugust.com>
|
Build failed.
|
jtopjian
requested changes
Jan 10, 2019
Contributor
jtopjian
left a comment
There was a problem hiding this comment.
@emonty Overall, this looks good - thank you!
Travis is reporting formatting issues: https://travis-ci.org/gophercloud/gophercloud/jobs/477603934#L985
I can't visually see a difference, so maybe it's a tab/spacing thing? Configuring your editor to run gofmt when saving/exiting a file is the best way to avoid these issues.
The other minor issue is the JSON syntax.
| "connection_limit": 1001 | ||
| "connection_limit": 1001, | ||
| "timeout_client_data": 181000, | ||
| "timeout_member_data": 181000, |
Contributor
There was a problem hiding this comment.
The comma at the end of this line is causing the unit test to fail.
Contributor
Author
|
I think the format fail on those lines were tabs inside the line (to make the assignments line up) I tried gofmt and it didn't correct it - but maybe that's just an edgecase. In any case - fix coming, thanks! |
cc43da5 to
b414da9
Compare
1 similar comment
|
Build succeeded.
|
Contributor
Author
|
@jtopjian yes- I believe so. thanks! |
emonty
added a commit
to emonty/cloud-provider-openstack
that referenced
this pull request
Jan 14, 2019
The octavia loadbalancer supports setting timeouts for client and member data connections. For some operations, such as pushing git large git repositories over an ssh connection, it is very important to be able to increase the timeout. This adds two annotations that allows a user to create a load balancer and set its timeout_client_data and timeout_member_data fields. Depends-On: gophercloud/gophercloud#1394 Signed-off-by: Monty Taylor <mordred@inaugust.com>
emonty
added a commit
to emonty/cloud-provider-openstack
that referenced
this pull request
Jan 15, 2019
The octavia loadbalancer supports setting timeouts for client and member data connections. For some operations, such as pushing git large git repositories over an ssh connection, it is very important to be able to increase the timeout. This adds two annotations that allows a user to create a load balancer and set its timeout_client_data and timeout_member_data fields. Depends-On: gophercloud/gophercloud#1394 Signed-off-by: Monty Taylor <mordred@inaugust.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1393
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://developer.openstack.org/api-ref/load-balancer/v2/?expanded=update-a-listener-detail#update-a-listener
http://git.openstack.org/cgit/openstack/octavia/tree/octavia/api/v2/types/listener.py#n53
http://git.openstack.org/cgit/openstack/octavia/tree/octavia/api/v2/types/listener.py#n55