Add RRSIG and DNSKEY record types to DNS layer#92
Merged
mosajjal merged 3 commits intogopacket:masterfrom Oct 25, 2024
Merged
Conversation
This was referenced Oct 17, 2024
Closed
Contributor
Author
|
I have tested it in my environment, and it appears to work fine. |
Contributor
Author
|
DNSKEY works fine too. |
Contributor
Author
|
Issue can be found here: #91 |
mosajjal
requested changes
Oct 19, 2024
Contributor
mosajjal
left a comment
There was a problem hiding this comment.
looks good. can you please added a few packets with and without DNSSEC to the test files as well.
Contributor
Author
|
OK, I will finish it asap. |
test: add RRSIG and DNSKEY test cases in test file.
Contributor
Author
|
Done. |
mosajjal
approved these changes
Oct 25, 2024
wader
pushed a commit
to wader/gopacket
that referenced
this pull request
Oct 25, 2024
* feat: add RRSIG and DNSKEY record types to DNS layer * feat: enhance DNS record types. * feat: implement RRSIG and DNSKEY decoding and encoding test: add RRSIG and DNSKEY test cases in test file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for RRSIG and DNSKEY record types in the DNS layer. The changes include the addition of these record types to the DNSType enumeration, as well as the implementation of their respective structures, encoding methods, and size calculations. This enhancement allows for better handling of DNSSEC-related records, improving the overall functionality of the DNS module.