Add MPTCP Options in the TCP Layer Decoder#66
Merged
mosajjal merged 1 commit intogopacket:masterfrom Nov 9, 2024
Merged
Conversation
6ed49f5 to
02a016a
Compare
Contributor
Author
|
(I just rebased this branch on top of |
02a016a to
233ab7f
Compare
233ab7f to
31fc321
Compare
Contributor
Author
|
FYI, the code from this PR has been tested via mozillazg/ptcpdump#152 |
mosajjal
reviewed
Oct 4, 2024
- Support for decoding MPTCPv0 (RFC6824) and MPTCPv1 (RFC8684) packets - Tests for MPTCP Co-authored-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Co-authored-by: Huang Huang <mozillazg101@gmail.com>
31fc321 to
2b023b1
Compare
mosajjal
approved these changes
Nov 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #63.
Work from @nkeukeleire, originally published on google/gopacket#870.
On top of that, I did a rebase, fixed the conflicts, a few typos, ran the tests, nothing major.