Closed
Conversation
Currently, packets with MPTCP options are not recognised: Unknown(30) MPTCP packets are using the option 30 according to the IANA. Link: https://www.iana.org/assignments/tcp-parameters/tcp-parameters.xhtml
Contributor
Author
|
Just after having created this PR, I found this other PR on the Google repo, doing a more complete work: google/gopacket#870 Do you think this PR could be accepted here? |
Contributor
|
yep happy to bring those PRs here. might as well close this one and create another one from that one. |
Contributor
Author
|
Replaced by #66 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
First, thank you for developing and maintaining this useful lib!
Currently, packets with MPTCP options are not recognised:
MPTCP packets are using the option 30 according to the IANA.
For more details about MPTCP: