fix: add x86_64-unknown-linux-musl build target#112
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
🦋 Changeset detectedLatest commit: 83256ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Need cla signed. |
|
I have signed the Google CLA — please re-check. |
|
conflicts to resolve |
5751c2d to
f5af70d
Compare
|
Rebased and resolved the conflicts with the new aarch64 targets on main. Ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
=======================================
Coverage 55.19% 55.19%
=======================================
Files 38 38
Lines 13166 13166
=======================================
Hits 7267 7267
Misses 5899 5899 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f5af70d to
c6d7ee0
Compare
When glibc isn't compatible (Alpine, NixOS, Docker scratch images), the npm install script falls back to a static musl binary. However, no musl target was configured in dist-workspace.toml, causing the fallback to fail with "Platform not supported". Fixes #86
c6d7ee0 to
83256ba
Compare
…leworkspace#112) When glibc isn't compatible (Alpine, NixOS, Docker scratch images), the npm install script falls back to a static musl binary. However, no musl target was configured in dist-workspace.toml, causing the fallback to fail with "Platform not supported". Fixes googleworkspace#86
…leworkspace#112) When glibc isn't compatible (Alpine, NixOS, Docker scratch images), the npm install script falls back to a static musl binary. However, no musl target was configured in dist-workspace.toml, causing the fallback to fail with "Platform not supported". Fixes googleworkspace#86
Summary
x86_64-unknown-linux-muslto cargo-dist build targets indist-workspace.tomlFixes #86
Problem
When installing via npm on a musl-based Linux system, the install script detects glibc incompatibility and tries to fall back to a static musl binary. However, no musl target was configured, so the fallback fails with:
Solution
Add
x86_64-unknown-linux-muslto the targets list so cargo-dist builds and publishes a statically-linked musl binary alongside the glibc variant. The npm install script's existing musl fallback logic will then find and use this binary.Test plan