Skip to content

fix: Remove listeners in GoogleMap.cameraEvents(): Flow<CameraEvent> implementation#82

Merged
arriolac merged 1 commit into
googlemaps:masterfrom
ychescale9:yc/remove-listeners-in-map-event-flow
Jul 21, 2020
Merged

fix: Remove listeners in GoogleMap.cameraEvents(): Flow<CameraEvent> implementation#82
arriolac merged 1 commit into
googlemaps:masterfrom
ychescale9:yc/remove-listeners-in-map-event-flow

Conversation

@ychescale9

@ychescale9 ychescale9 commented Jul 18, 2020

Copy link
Copy Markdown
Contributor

Fixes #80.

  • Removed the added listeners in the awaitClose within the GoogleMap.cameraEvents(): Flow<CameraEvent> implementation.
  • Removed the unnecessary inline keyword as the function has no parameters of function types.

Also made a couple of unrelated changes (let me know if you want them in a separate PR):

  • Also bumped coroutines to version 1.3.8
  • changed kotlin-stdlib-jdk7 to kotlin-stdlib as no Java 7 APIs are used.

Ran ./gradlew assemble check locally.

@googlebot

googlebot commented Jul 18, 2020

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 18, 2020
@ychescale9

ychescale9 commented Jul 18, 2020

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot

googlebot commented Jul 18, 2020

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 18, 2020
@codecov

codecov Bot commented Jul 18, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #82   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          28      28           
  Lines         172     186   +14     
  Branches       26      26           
======================================
- Misses        172     186   +14
Impacted Files Coverage Δ
...main/java/com/google/maps/android/ktx/GoogleMap.kt 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b43bbde...3888baa. Read the comment docs.

@ychescale9 ychescale9 changed the title Remove listeners in GoogleMap.cameraEvents(): Flow<CameraEvent> implementation fix - Remove listeners in GoogleMap.cameraEvents(): Flow<CameraEvent> implementation Jul 18, 2020
@ychescale9 ychescale9 changed the title fix - Remove listeners in GoogleMap.cameraEvents(): Flow<CameraEvent> implementation fix: Remove listeners in GoogleMap.cameraEvents(): Flow<CameraEvent> implementation Jul 18, 2020
@ychescale9 ychescale9 force-pushed the yc/remove-listeners-in-map-event-flow branch 2 times, most recently from 47fc9d9 to 1503ee8 Compare July 18, 2020 08:41
@barbeau barbeau assigned arriolac and unassigned barbeau Jul 18, 2020
@barbeau barbeau requested a review from arriolac July 18, 2020 20:10
arriolac
arriolac reviewed Jul 20, 2020
View reviewed changes

@arriolac arriolac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending us a PR! I have one stylistic comment, other than that, it looks good to me.

Comment thread maps-ktx/src/main/java/com/google/maps/android/ktx/GoogleMap.kt Outdated
@ychescale9
fix: Remove listeners in awaitClose block in GoogleMaps.cameraEvents(…
3888baa 
…): Flow<CameraEvent> implementation and remove unnecessary inline.
@ychescale9 ychescale9 force-pushed the yc/remove-listeners-in-map-event-flow branch from 1503ee8 to 3888baa Compare July 20, 2020 23:29
@arriolac arriolac merged commit 7756605 into googlemaps:master Jul 21, 2020
googlemaps-bot pushed a commit that referenced this pull request Jul 21, 2020
@semantic-release-bot
chore(release): 2.1.1 [skip ci]
5fe6ec7 
## [2.1.1](v2.1.0...v2.1.1) (2020-07-21)

### Bug Fixes

* Remove listeners in awaitClose block in GoogleMaps.cameraEvents(): Flow<CameraEvent> implementation and remove unnecessary inline. ([#82](#82)) ([7756605](7756605))
@googlemaps-bot

googlemaps-bot commented Jul 21, 2020

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ychescale9 ychescale9 deleted the yc/remove-listeners-in-map-event-flow branch July 21, 2020 17:16
@googlemaps-bot googlemaps-bot mentioned this pull request Dec 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arriolac arriolac arriolac approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@arriolac arriolac

Labels

cla: yes This human has signed the Contributor License Agreement. released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

android-maps-ktx: Listeners aren't removed in awaitClose block in cameraEvents(): Flow implementation

5 participants

@ychescale9 @googlebot @googlemaps-bot @arriolac @barbeau