Skip to content

fix!: upgraded Maps Utils and Gradle#216

Merged
wangela merged 7 commits into
mainfrom
fix/upgraded_maps_utils_and_gradle
Oct 27, 2023
Merged

fix!: upgraded Maps Utils and Gradle#216
wangela merged 7 commits into
mainfrom
fix/upgraded_maps_utils_and_gradle

Conversation

@kikoso

@kikoso kikoso commented Oct 4, 2023

Copy link
Copy Markdown
Collaborator

This PR fixes the MyItem class from android-maps-utils, and upgrades as well to AGP 8.1

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #215 🦕

@wangela

wangela commented Oct 4, 2023

Copy link
Copy Markdown
Member

We should also fix .releaserc to add a pattern that looks to update the line in app/build.gradle with each release. Similar to how .releaserc in android-maps-utils does it.

@kikoso kikoso force-pushed the fix/upgraded_maps_utils_and_gradle branch from 72b3302 to fa8bcc9 Compare October 26, 2023 16:45
wangela
wangela reviewed Oct 26, 2023
View reviewed changes
Comment thread app/src/main/java/com/google/maps/android/ktx/demo/model/MyItem.kt
@kikoso kikoso changed the title fix: upgraded Maps Utils and Gradle fix!: upgraded Maps Utils and Gradle Oct 26, 2023
wangela
wangela requested changes Oct 27, 2023
View reviewed changes
Comment thread build.gradle
@snippet-bot

snippet-bot Bot commented Oct 27, 2023

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@wangela

wangela commented Oct 27, 2023

Copy link
Copy Markdown
Member

We should also fix .releaserc to add a pattern that looks to update the line in app/build.gradle with each release. Similar to how .releaserc in android-maps-utils does it.

Decided to do this in a separate PR.

@wangela wangela merged commit ac28a84 into main Oct 27, 2023
@wangela wangela deleted the fix/upgraded_maps_utils_and_gradle branch October 27, 2023 23:02
googlemaps-bot pushed a commit that referenced this pull request Oct 27, 2023
@semantic-release-bot
chore(release): 5.0.0 [skip ci]
ae9d708 
# [5.0.0](v4.0.0...v5.0.0) (2023-10-27)

### Bug Fixes

* upgrade build dependencies ([#216](#216)) ([ac28a84](ac28a84))

### BREAKING CHANGES

* Since android-maps-utils v3.2.0 introduced z-index to marker clusters, this change propagates that change. See release notes from android-maps-utils v3.2.0 https://github.com/googlemaps/android-maps-utils/releases/tag/v3.2.0
@googlemaps-bot

googlemaps-bot commented Oct 27, 2023

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@googlemaps-bot googlemaps-bot mentioned this pull request Dec 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangela wangela wangela approved these changes

Assignees

@wangela wangela

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests failing due to demo app for ClusterItem

3 participants

@kikoso @wangela @googlemaps-bot