Skip to content

fix!: updated Gradle version, plugins and libraries#212

Merged
wangela merged 7 commits into
mainfrom
feat/updated_gradle_version_plugins_libraries
Sep 26, 2023
Merged

fix!: updated Gradle version, plugins and libraries#212
wangela merged 7 commits into
mainfrom
feat/updated_gradle_version_plugins_libraries

Conversation

@kikoso

@kikoso kikoso commented Sep 15, 2023

Copy link
Copy Markdown
Collaborator

This PR updates the AGP version, and that of several plugins and libraries. A small step for humankind, a big step for us.


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #206 🦕
Fixes #192
Fixes #156

@kikoso kikoso requested review from a team and jonesfloyd September 15, 2023 07:32
@kikoso kikoso force-pushed the feat/updated_gradle_version_plugins_libraries branch from c5b3183 to 7923f0a Compare September 15, 2023 07:33
Comment thread README.md
Comment thread build.gradle Outdated
Comment thread build.gradle Outdated
Comment thread build.gradle
@wangela wangela changed the title chore: updated Gradle version, plugins and libraries chore!: updated Gradle version, plugins and libraries Sep 16, 2023
@wangela

wangela commented Sep 16, 2023

Copy link
Copy Markdown
Member

Since this removes the v3 beta, this will be considered a breaking change and require a major version bump. We are also fixing ambiguity about which dependency wins (transitive dependency on Maps SDK and Maps Utils in the build.gradle or explicitly added dependency recommended in the README) so promoting this from a chore to a fix.

@wangela wangela changed the title chore!: updated Gradle version, plugins and libraries fix!: updated Gradle version, plugins and libraries Sep 16, 2023
@kikoso

kikoso commented Sep 18, 2023

Copy link
Copy Markdown
Collaborator Author

Since this removes the v3 beta, this will be considered a breaking change and require a major version bump. We are also fixing ambiguity about which dependency wins (transitive dependency on Maps SDK and Maps Utils in the build.gradle or explicitly added dependency recommended in the README) so promoting this from a chore to a fix.

Makes sense, arguably this is not a mere version or doc update anymore.

@kikoso

kikoso commented Sep 19, 2023

Copy link
Copy Markdown
Collaborator Author

This should fix #156 too

@wangela wangela left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit!

Comment thread app/build.gradle Outdated
implementation 'androidx.lifecycle:lifecycle-runtime-ktx:2.4.1'
implementation 'com.google.android.gms:play-services-maps:18.1.0'
// implementation 'com.google.maps.android:maps-ktx:3.0.1'
//implementation 'com.google.maps.android:maps-ktx:3.4.0'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there needs to be a space after the //

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly from a Gradle perspective, but I am not sure if the documentation script needs it. I have re-added it.

@wangela wangela merged commit d622499 into main Sep 26, 2023
@wangela wangela deleted the feat/updated_gradle_version_plugins_libraries branch September 26, 2023 15:11
googlemaps-bot pushed a commit that referenced this pull request Sep 26, 2023
# [4.0.0](v3.4.0...v4.0.0) (2023-09-26)

* fix!: updated Gradle version, plugins and libraries (#212) ([d622499](d622499)), closes [#212](#212)

### BREAKING CHANGES

* remove v3 beta

* chore: updated docs

* chore: updated Gradle version, plugins and libraries

* feat: updated Kotlin and dokka

* chore: removed deprecated method
@googlemaps-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update and clarify dependencies for KTX libraries Remove deprecated v3 versions Update dokka integration

3 participants