fix: Rename awaitAnimation to awaitAnimateCamera#126
Merged
Conversation
Renamed suspending function to match wrapped method name which is more specific. BREAKING CHANGE: awaitAnimation renamed to awaitAnimateCamera
Codecov Report
@@ Coverage Diff @@
## main #126 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 28
Lines ? 202
Branches ? 27
======================================
Hits ? 0
Misses ? 202
Partials ? 0 Continue to review full report at Codecov.
|
googlemaps-bot
pushed a commit
that referenced
this pull request
Mar 5, 2021
# [3.0.0](v2.4.0...v3.0.0) (2021-03-05) ### Bug Fixes * Rename awaitAnimation to awaitAnimateCamera ([#126](#126)) ([770b068](770b068)) ### BREAKING CHANGES * awaitAnimation renamed to awaitAnimateCamera * Disable jacoco * Attempt to fix NoClassDef erro.
Contributor
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed
awaitAnimationtoawaitAnimateCamerato match the underlying method name. Not only does this match the original method, but this is also a lot more specific. The former method name could be confusing since it's not clear what is being animated.BREAKING CHANGE: Renamed
awaitAnimationtoawaitAnimateCamera