Yeah, I did that in the merge commit, and now we have incompatible requirements. Aargh.

Something's very wrong here: openstep_plist should be marked as a dependency. And the tests should fail if we're not installing it?!

It is a dependency? I can see it in setup.cfg and requirements.txt?

Oh I see, the regression test should fail but doesn't. I think that's because I marked it as can-fail. Let's try without...

OK, I see it. We're checking out main, installing the dependencies from that (which does not have the new openstep dep), then checking out the branch later. We should probably add another step to the workflow which re-installs the dependencies after switching branches.

I just saw that, yes. Let's see.

Something is flipping smooth flags :o

But only some of them. And I can't reproduce locally. Annoying.

I can reproduce this now. I don't understand it, but some clues: it only happens in (i) background glyphs (ii) which are made up of components. and (iii) in the regression test framework - not via glyphs2ufo.

Also, the "new" version is arguably correct. For example, in the master branch, Karla UltraBold Italic has this when decomposing the background of dcroat:

      <point x="748" y="647"/>
      <point x="747" y="532" type="curve"/>
      <point x="747" y="524"/>

But the glyphs3 branch has:

      <point x="748" y="647"/>
      <point x="747" y="532" type="curve" smooth="yes"/>
      <point x="747" y="524"/>

The original d which is being decomposed is:

The question is not "Why is glyphs3 adding a smooth flag?" but "Why is the main branch dropping one?"

• Sometimes, the flag is added: https://github.com/googlefonts/glyphsLib/pull/691/checks?check_run_id=3238636620#step:8:6536
• Other times, it is removed: https://github.com/googlefonts/glyphsLib/pull/691/checks?check_run_id=3238636620#step:8:6597

The diff is the wrong way around.

Here it is removed, no? https://github.com/googlefonts/glyphsLib/pull/691/checks?check_run_id=3239793037#step:8:2297
And here it is added? https://github.com/googlefonts/glyphsLib/pull/691/checks?check_run_id=3239793037#step:8:461

That's not the point. The point is, which is right? Which is wrong?

One which is added:

! /tmp/tmp0ujjlwis/Playball-Regular.ufo/glyphs.public.background/uhungarumlaut.glif - tests/data/gf/Playball/Playball-Regular.ufo/glyphs.public.background/uhungarumlaut.glif--- 
+++ 
@@ -62,7 +62,7 @@
       <point x="345" y="345" type="curve" smooth="yes"/>
       <point x="305" y="281"/>
       <point x="211" y="61"/>
-      <point x="148" y="59" type="curve"/>
+      <point x="148" y="59" type="curve" smooth="yes"/>
       <point x="127" y="59"/>
       <point x="120" y="75"/>
       <point x="120" y="97" type="curve" smooth="yes"/>

Glyphs source has "148 59 CURVE SMOOTH" so master is correct here. OK, I got confused earlier.

But I have no idea why this is happening. And why it is happening now, when it wasn't happening before.

However, I am getting the same result (no "smooth" for that point) on main now locally!

I bet you this is the problem:

-fonttools[ufo,unicode]==4.21.1
+fonttools[ufo,unicode]==4.25.2

$ cat is-point-smooth.py
import glyphsLib
import logging
import fontTools

logging.basicConfig(level=logging.ERROR)
ufos = glyphsLib.load_to_ufos("tests/data/gf/Playball.glyphs")

print(fontTools.__version__)
print(ufos[0].layers["public.background"]["uhungarumlaut"][0][60].smooth)

$ python3 is-point-smooth.py
4.21.1
True

$ python3 is-point-smooth.py
4.25.2
False

Now what?

Ship it!

Merging this now and tagging a pre-release. Thanks!