Rework parser and writer (G3 prep)#690
Conversation
Bumps [lxml](https://github.com/lxml/lxml) from 4.6.2 to 4.6.3. - [Release notes](https://github.com/lxml/lxml/releases) - [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt) - [Commits](lxml/lxml@lxml-4.6.2...lxml-4.6.3) Signed-off-by: dependabot[bot] <support@github.com>
9df67ab to
2faf779
Compare
|
Well, the first commit is a bad rebase, but the other three are as described... |
_classesForName, _wrapperKeysTranslate, shouldWriteValueForKey, _keyOrder
2faf779 to
572f7ba
Compare
| "showMeasurement": bool, | ||
| "filter": str, | ||
| "name": str, | ||
| } |
There was a problem hiding this comment.
Happy to see this stuff gone!
|
I don't think this is G3-specific, but TrueType hints can have 3 values in origin and target. That happens when the hinted point is one that will only be inserted when converting to TrueType, like an inflection point. Here's an example file that fails when trying to parse the hints: S.glyphs.zip |
|
The hints in your file don't parse using the main branch of glyphsLib, even if I convert it to Glyphs 2 file format, so the fact that the hints don't parse is not specific to this PR. I think what you're saying is a duplicate of #446. |
|
Right! Yes, they didn’t ever parse. I just thought you might want to fix it for G3 files :) |
|
Sure. Happy to fix for G2 and G3, but I'd rather do things in separate steps to help reviewers; the "rejigging the parser" component is big enough to be a single PR by itself, we can fix unconnected open issues later... |
I'm going to do the Glyphs 3 branch again, now I know what I'm doing.
This PR is preparatory work for Glyphs 3 support, but there is nothing G3 specific about it at this stage. It consists of three commits, each of which passes tests independently when applied in sequence.