-
Notifications
You must be signed in to change notification settings - Fork 93
chore(python_mono_repo): clean up prerelease_deps and core_deps_from_source #2071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ffc8bd to
197bb5f
Compare
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Mar 11, 2025
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Mar 11, 2025
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Mar 11, 2025
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Mar 11, 2025
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Mar 11, 2025
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Mar 11, 2025
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Mar 11, 2025
197bb5f to
3b890c6
Compare
vchudnov-g
approved these changes
Mar 11, 2025
Contributor
vchudnov-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One non-trivial but minor comment about the try/catch.
vchudnov-g
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Mar 14, 2025
Update to the newest version of the post processor which includes the changes from googleapis/synthtool#2071 Run the following commands to obtain the latest sha256 ``` docker pull gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest ``` ``` docker inspect --format='{{.RepoDigests}}' gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest [gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo@sha256:1f0395c6ed234c13632415ed0bf904591c10b876769347b2732a1f043364f311] ```
Carol25170
reviewed
Apr 3, 2025
Carol25170
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will address feedback from code review in googleapis/google-cloud-python#13637. The following fixes are included:
prerelease_depsandcore_deps_from_sourceprerelease_depsandcore_deps_from_source