fix(java): make license header fixing idempotent#1008
Merged
chingor13 merged 7 commits intogoogleapis:masterfrom Mar 31, 2021
Merged
fix(java): make license header fixing idempotent#1008chingor13 merged 7 commits intogoogleapis:masterfrom
chingor13 merged 7 commits intogoogleapis:masterfrom
Conversation
SurferJeffAtGoogle
suggested changes
Mar 31, 2021
bcoe
approved these changes
Mar 31, 2021
bcoe
reviewed
Mar 31, 2021
| DEFAULT_FORMAT_VERSION = "1.7" | ||
| GOOD_LICENSE = """ | ||
| /* | ||
| GOOD_LICENSE = """/* |
There was a problem hiding this comment.
I notice that GOOD_LICENSE has 2020 hardcoded into it, do we need to update this date over time? how does this work for new libraries.
Contributor
Author
There was a problem hiding this comment.
Will update separately.
SurferJeffAtGoogle
approved these changes
Mar 31, 2021
bcoe
pushed a commit
that referenced
this pull request
Oct 13, 2021
bcoe
pushed a commit
that referenced
this pull request
Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1007