chore: re-work build infra, primarily around code format machinery #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #915 +/- ##
=======================================
Coverage 87.96% 87.96%
=======================================
Files 156 156
Lines 16198 16198
Branches 1179 1179
=======================================
Hits 14248 14248
Misses 1608 1608
Partials 342 342
Continue to review full report at Codecov.
|
meltsufin
approved these changes
Jan 28, 2022
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
) - Removes `gapic_generator_java.bzl`. - `:google_java_format_verification` is now working. (Fixes #914.) - `:google_java_format_verification` now runs with `bazel run` instead of `bazel build`, which is consistent with how `:google_java_format` runs. - Removes manual listing of files to format, which is error-prone. This actually revealed that we were missing out some files for formatting. (For example, `AbstractTransportServiceStubClassComposer.java` had an unused import.) - Removes unnecessary `filegroup` definitions triggered by removing manual file listing. - Reduces visibility of many packages.
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
gapic_generator_java.bzl.:google_java_format_verificationis now working. (Fixesgoogle_java_format_verificationis broken #914.):google_java_format_verificationnow runs withbazel runinstead ofbazel build, which is consistent with how:google_java_formatruns.Removes manual listing of files to format, which is error-prone. This actually revealed that we were missing out some files for formatting. (For example,
AbstractTransportServiceStubClassComposer.javahad an unused import.)Removes unnecessary
filegroupdefinitions triggered by removing manual file listing.Reduces visibility of many packages.