Skip to content

Conversation

@miraleung
Copy link
Contributor

@miraleung miraleung commented Jun 21, 2021

Any golden file updates are due to bumping the googleapis hash. This can't go in until googleapis_discovery has removed the monolith as well.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #778 (582854f) into master (9432979) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #778   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         140      140           
  Lines       14952    14952           
  Branches     1074     1074           
=======================================
  Hits        13648    13648           
  Misses       1011     1011           
  Partials      293      293           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9432979...582854f. Read the comment docs.

@miraleung miraleung marked this pull request as ready for review June 30, 2021 18:57
@miraleung miraleung requested a review from a team June 30, 2021 18:57
@miraleung miraleung requested a review from vam-google June 30, 2021 18:57
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants