Skip to content

Conversation

@miraleung
Copy link
Contributor

No description provided.

@miraleung miraleung requested a review from a team June 1, 2021 19:44
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2021
@miraleung miraleung requested a review from vam-google June 1, 2021 19:45
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

❗ No coverage uploaded for pull request base (fix/test_field_order@fe4006e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                   @@
##             fix/test_field_order     #744   +/-   ##
=======================================================
  Coverage                        ?   91.43%           
=======================================================
  Files                           ?      133           
  Lines                           ?    13874           
  Branches                        ?     1031           
=======================================================
  Hits                            ?    12686           
  Misses                          ?      907           
  Partials                        ?      281           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe4006e...1483773. Read the comment docs.

Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vam-google vam-google merged commit d4783a6 into fix/test_field_order Jun 1, 2021
@vam-google vam-google deleted the fix/bazel_integ_tests branch June 1, 2021 20:05
@miraleung miraleung restored the fix/bazel_integ_tests branch June 1, 2021 20:27
miraleung added a commit that referenced this pull request Jun 2, 2021
…#743)

* fix(tests): Ensure deterministic field ordering in test classes

* fix(bazel): fix recursive integration test file diffs (#744)
vam-google added a commit that referenced this pull request Jun 7, 2021
ntegration tests (compute_small) are not present in this commit, as they depend on #743 and #744. Also, as a prerequisite, at least a basic implementation of DIREGAPIC must be merged in gapic-generator-java, to integrate it with [googleapis-discovery](https://github.com/googleapis/googleapis-discovery) first (since integration test infra depends on the actual googleapis/googleapis-discovery targets). Please check vam-google@8983e23 to see how it would look like with compute integration tests not excluded.


`compliance.proto` is used as a basis for the REST composer tests. It was copied as is from [showcase/compliance.proto](https://github.com/googleapis/gapic-showcase/blob/master/schema/google/showcase/v1beta1/compliance.proto).

Changes in `WORKSPACE` and `repositories.bzl` are necessary to make this repo work with gax-java `1.63.0` and above (`gax-java` vs `gapic-generator-java` java dependencies imports precedence). The other dependencies changes are either to bring deps in sync with the actual ones in googleapis, or to fix a specific import precedence issue.

I also added (in a form of bazel rules) a proto descriptor dumper and a runner from the dumped file (for debugging purposes). Not technically required here (but was very helpful for debugging purposes, so hopefully we can preserve it).
@chanseokoh chanseokoh deleted the fix/bazel_integ_tests branch November 10, 2021 15:53
suztomo pushed a commit that referenced this pull request Mar 21, 2023
suztomo pushed a commit that referenced this pull request Mar 21, 2023
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants