Merge Sample Code into Master #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @chingor13, we complete the sample code implementation in |
miraleung
suggested changes
Jan 25, 2021
Contributor
miraleung
left a comment
There was a problem hiding this comment.
Could you please run the commands to double-check this as well (shared via chat)?
Contributor
Author
|
@miraleung These two PR is not change the code surface. So it will not be the blocker, but I prefer to wait these RPs. |
Contributor
Author
|
@miraleung @chingor13 Please take another look. After point |
miraleung
approved these changes
Jan 26, 2021
Contributor
miraleung
left a comment
There was a problem hiding this comment.
Please wait for chingor@ to approve the generated sample code (under test/integration/goldens).
chingor13
approved these changes
Jan 28, 2021
Neenu1995
approved these changes
Jan 29, 2021
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.4](https://www.github.com/googleapis/java-core/compare/v2.3.3...v2.3.4) (2022-01-06) ### Bug Fixes * fixed compilation warnings from error prone ([e424c31](https://www.github.com/googleapis/java-core/commit/e424c31af5bffcce76b60095ebcf3dc7e57e0aae)) * **java:** add -ntp flag to native image testing command ([#1299](https://www.github.com/googleapis/java-core/issues/1299)) ([#643](https://www.github.com/googleapis/java-core/issues/643)) ([0c16f02](https://www.github.com/googleapis/java-core/commit/0c16f02187a6dd66f5c41d104a4dc719fe43914e)) * **java:** run Maven in plain console-friendly mode ([#1301](https://www.github.com/googleapis/java-core/issues/1301)) ([#652](https://www.github.com/googleapis/java-core/issues/652)) ([fc4f72a](https://www.github.com/googleapis/java-core/commit/fc4f72ade71708cda01238c5b0865fb09850be70)) ### Dependencies * update dependency com.google.api-client:google-api-client-bom to v1.33.0 ([#658](https://www.github.com/googleapis/java-core/issues/658)) ([b275a7a](https://www.github.com/googleapis/java-core/commit/b275a7a904c14d0814a5b2b9b6e58bc0b1593e9c)) * update dependency com.google.api:gax-bom to v2.8.0 ([#659](https://www.github.com/googleapis/java-core/issues/659)) ([5f75cac](https://www.github.com/googleapis/java-core/commit/5f75cacec4edfe80fcc3b2b23ee5074c223bb6c6)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.7.1 ([#656](https://www.github.com/googleapis/java-core/issues/656)) ([9d96982](https://www.github.com/googleapis/java-core/commit/9d96982a28e09c6ed1870373877acec2be28fdcc)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.2.0 ([#645](https://www.github.com/googleapis/java-core/issues/645)) ([5e3a17d](https://www.github.com/googleapis/java-core/commit/5e3a17d1f2b9e6345c9b78ab2b6c28040be67c2f)) * update dependency com.google.http-client:google-http-client-bom to v1.41.0 ([#657](https://www.github.com/googleapis/java-core/issues/657)) ([e0b6d7d](https://www.github.com/googleapis/java-core/commit/e0b6d7d8e4f550d5232f331135511a31b988d599)) * update dependency com.google.protobuf:protobuf-bom to v3.19.2 ([#655](https://www.github.com/googleapis/java-core/issues/655)) ([881cb43](https://www.github.com/googleapis/java-core/commit/881cb430a6a5ee15520234012c36c1dc38aa8b29)) * update dependency io.grpc:grpc-bom to v1.43.1 ([#647](https://www.github.com/googleapis/java-core/issues/647)) ([29f8f34](https://www.github.com/googleapis/java-core/commit/29f8f34b7d4a5d142e43cd969c5bff185e0e2b82)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GAPIC java microgenerator requires a mechanism to generate the Javadoc comment for the classes and methods including the sample code snippets.
samplecode-masteris master branch for implementing the feature of generating sample codes. Within the sub branches of implementing sub component of sample code, we are ready to merge into themasterbranch and launch the this feature. Note that, some of the sample code already checked inmasterbefore, I marked down below.The requirements:
Test:
test/integration/goldenscontains all the generated sample code, includeasset,logging,credentials,redis, 'library'