[samplecode][2/3]Implement Stream.Bidi sample code #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miraleung
suggested changes
Jan 6, 2021
...java/com/google/api/generator/gapic/composer/samplecode/ServiceClientSampleCodeComposer.java
Outdated
Show resolved
Hide resolved
...java/com/google/api/generator/gapic/composer/samplecode/ServiceClientSampleCodeComposer.java
Outdated
Show resolved
Hide resolved
5a2cfa8 to
a14cc0a
Compare
miraleung
approved these changes
Jan 11, 2021
Contributor
miraleung
left a comment
There was a problem hiding this comment.
LGTM with comments addressed.
| // Create bidi stream variable expression and assign it with invoking client's bidi stream | ||
| // method. | ||
| // e.g. BidiStream<EchoRequest, EchoResponse> bidiStream = echoClient.chatCallable().call(); | ||
| TypeNode bidiStreamType = |
Contributor
There was a problem hiding this comment.
Since this method is already named bidi, do the variable names still need bidi in them?
Contributor
Author
There was a problem hiding this comment.
I used bidiStream to match the original sample code syntax, but I am open to the variable name. A stream variable in server is stream, so I think it make sense use stream instead of bidiStream. Are you also preferring using stream instead?
Contributor
There was a problem hiding this comment.
If it's for matching the variable name, then bidiStream LGTM.
Base automatically changed from
stream_server_sample_code
to
samplecode-master
January 11, 2021 23:57
miraleung
approved these changes
Jan 12, 2021
| // Create bidi stream variable expression and assign it with invoking client's bidi stream | ||
| // method. | ||
| // e.g. BidiStream<EchoRequest, EchoResponse> bidiStream = echoClient.chatCallable().call(); | ||
| TypeNode bidiStreamType = |
Contributor
There was a problem hiding this comment.
If it's for matching the variable name, then bidiStream LGTM.
summer-ji-eng
added a commit
that referenced
this pull request
Jan 15, 2021
suztomo
added a commit
that referenced
this pull request
Mar 21, 2023
While updating multiple dependencies in the BOM, it's ok to have inconsistent versions. But we want to ensure the consistent versioning when we make a release of the BOM. I copied the setting from https://github.com/googleapis/java-cloud-bom/blob/main/.github/workflows/full-convergence-check.yaml#L10
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.2](https://www.github.com/googleapis/java-core/compare/v2.3.1...v2.3.2) (2021-12-02) ### Dependencies * update dependency com.google.api:api-common to v2.1.1 ([#632](https://www.github.com/googleapis/java-core/issues/632)) ([6232ef6](https://www.github.com/googleapis/java-core/commit/6232ef6861e99b1d6afe85e16c4bf9b4ff5039a9)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.7.0 ([#638](https://www.github.com/googleapis/java-core/issues/638)) ([6c87f49](https://www.github.com/googleapis/java-core/commit/6c87f490808a208b814fdd93ca5bbc7aa64f4882)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement sample code for Stream.Bidi