[composer][samplecode]Implement Setting Class Header Comment Sample Code #487

summer-ji-eng · 2020-11-13T04:48:22Z

Generate sample code for ServiceSettingsClass header comment:

FoobarSettings.Builder foobarSettingsBuilder = FoobarSettings.newBuilder();
 foobarSettingsBuilder
   .<firstUnarySettingMethod>()
   .setRetrySettings(
       foobarSettingsBuilder
       .<firstUnarySettingMethod>()
       .getRetrySettings()
       .toBuilder()
       .setTotalTimeout(Duration.ofSeconds(30))
       .build());
FoobarSettings foobarSettings = foobarSettingsBuilder.build();

ServiceStubSettings header comment:

FoobarStubSettings.Builder foobarSettingsBuilder = FoobarSettings.newBuilder();
 foobarSettingsBuilder
   .<firstUnarySettingMethod>()
   .setRetrySettings(
       foobarSettingsBuilder
       .<firstUnarySettingMethod>()
       .getRetrySettings()
       .toBuilder()
       .setTotalTimeout(Duration.ofSeconds(30))
       .build());
FoobarStubSettings foobarSettings = foobarSettingsBuilder.build();

…enerator-java into sample_code_formatter

src/main/java/com/google/api/generator/gapic/composer/ServiceSettingsClassComposer.java

src/main/java/com/google/api/generator/gapic/composer/ServiceStubSettingsClassComposer.java

src/main/java/com/google/api/generator/gapic/composer/SettingsSampleCodeComposer.java

…/gapic-generator-java into setting_comment_sample_code_1

src/main/java/com/google/api/generator/gapic/composer/ServiceSettingsClassComposer.java

test/integration/goldens/asset/AssetServiceSettings.java

miraleung

LGTM with comments addressed.

src/main/java/com/google/api/generator/gapic/composer/ServiceSettingsClassComposer.java

src/main/java/com/google/api/generator/gapic/composer/SettingsSampleCodeComposer.java

…ode (#487)

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

* chore(java): rename master branch to main Source-Author: Neenu Shaji <Neenu1995@users.noreply.github.com> Source-Date: Mon Sep 27 10:04:11 2021 -0400 Source-Repo: googleapis/synthtool Source-Sha: 67ab4f9f4272ad13f4b809de47fd0dec05f425ad Source-Link: googleapis/synthtool@67ab4f9 * build: add jdk 17 to java units and dependency builds * update dependencies.sh to not pass MaxPermSize when jdk 17 is used. MaxPermSize is an unrecognized flag in jdk 17. Source-Author: BenWhitehead <BenWhitehead@users.noreply.github.com> Source-Date: Mon Sep 27 11:34:46 2021 -0400 Source-Repo: googleapis/synthtool Source-Sha: a4be3384ccb92364795d981f2863f6986fcee620 Source-Link: googleapis/synthtool@a4be338

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/e278faaf-4497-439c-a104-7bdeda21de9b/targets - [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.) Source-Link: googleapis/synthtool@09c59c2

summer-ji-eng added 27 commits November 9, 2020 17:00

draft version

2cb0d9f

Add unit test for long line

2bf804e

Implement formatter for code snippet

b0c6b47

Add license and comment

94bd9ed

Merge branch 'master' into sample_code_formatter

209ec9d

Use string as input parameters

7176a85

remove unused dep

62da37b

Merge branch 'master' into sample_code_formatter

c9213eb

draft version

07d9d21

Add unit test for long line

55c7604

Implement formatter for code snippet

9f1b49d

Add license and comment

3126e5f

Use string as input parameters

308e6cf

remove unused dep

e2f99ab

move utils to composer/samplecode

e2d2a40

Merge branch 'sample_code_formatter' of github.com:googleapis/gapic-g…

875794f

…enerator-java into sample_code_formatter

remove utils files

40977cf

revert BUILD in test

ad842eb

Merge branch 'master' into sample_code_formatter

4426dd2

Merge branch 'master' into sample_code_formatter

2cfa86f

Add comment and rephrase static string

222c910

simplify the wrapper

7ca32d8

Merge branch 'master' into sample_code_formatter

4f91c12

Merge branch 'master' into sample_code_formatter

ef1a81d

compose sample code for settings and stub settings

67a66e5

Pick first pure unary method

dadd3b8

resolve merge master

219fca1

summer-ji-eng requested review from miraleung and xiaozhenliu-gg5 as code owners November 13, 2020 04:48

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 13, 2020

summer-ji-eng added 5 commits November 12, 2020 21:12

pick first unary rpc for setting class

dd1c881

Add comment for method pick

cbeabad

Merge branch 'master' into setting_comment_sample_code_1

5b602b5

Update code mark in sample code

38bd06c

move out from samplecode

be274d6

miraleung suggested changes Nov 16, 2020

View reviewed changes

product-auto-label bot added the samples Issues that are directly related to samples. label Nov 16, 2020

Merge branch 'master' into setting_comment_sample_code_1

1798c01

summer-ji-eng mentioned this pull request Nov 17, 2020

[composer][samplecode]Add writeSampleCode method #499

Merged

summer-ji-eng added 2 commits November 16, 2020 17:25

Add comments in composing sample code

95019b0

Merge branch 'setting_comment_sample_code_1' of github.com:googleapis…

801939a

…/gapic-generator-java into setting_comment_sample_code_1

summer-ji-eng requested a review from miraleung November 17, 2020 01:26

xiaozhenliu-gg5 approved these changes Nov 17, 2020

View reviewed changes

src/main/java/com/google/api/generator/gapic/composer/ServiceSettingsClassComposer.java Show resolved Hide resolved

test/integration/goldens/asset/AssetServiceSettings.java Show resolved Hide resolved

miraleung suggested changes Nov 17, 2020

View reviewed changes

src/main/java/com/google/api/generator/gapic/composer/ServiceSettingsClassComposer.java Outdated Show resolved Hide resolved

Merge branch 'master' into setting_comment_sample_code_1

210f606

summer-ji-eng requested a review from miraleung November 17, 2020 20:08

replace reduce by filter

06cb0f8

miraleung suggested changes Nov 17, 2020

View reviewed changes

src/main/java/com/google/api/generator/gapic/composer/ServiceSettingsClassComposer.java Outdated Show resolved Hide resolved

src/main/java/com/google/api/generator/gapic/composer/SettingsSampleCodeComposer.java Outdated Show resolved Hide resolved

summer-ji-eng requested a review from miraleung November 17, 2020 21:36

summer-ji-eng added 2 commits November 17, 2020 13:38

simplify the orElse

2c111d1

Merge branch 'master' into setting_comment_sample_code_1

39749d1

miraleung approved these changes Nov 18, 2020

View reviewed changes

summer-ji-eng added 2 commits November 17, 2020 18:32

Merge branch 'master' into setting_comment_sample_code_1

933db28

Merge branch 'master' into setting_comment_sample_code_1

39457ef

summer-ji-eng merged commit d3dce05 into master Nov 18, 2020

summer-ji-eng deleted the setting_comment_sample_code_1 branch November 18, 2020 07:34

summer-ji-eng added a commit that referenced this pull request Nov 18, 2020

[composer][samplecode]Implement Setting Class Header Comment Sample C…

565eec4

…ode (#487)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[composer][samplecode]Implement Setting Class Header Comment Sample Code #487

[composer][samplecode]Implement Setting Class Header Comment Sample Code #487

Uh oh!

summer-ji-eng commented Nov 13, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miraleung left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[composer][samplecode]Implement Setting Class Header Comment Sample Code #487

[composer][samplecode]Implement Setting Class Header Comment Sample Code #487

Uh oh!

Conversation

summer-ji-eng commented Nov 13, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miraleung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants