Conversation
|
|
||
| ## 4. Testing | ||
|
|
||
| ### 4.1. Testing Strategy |
There was a problem hiding this comment.
Does adding links to existing documentation pages work for gemini? I think we'd want to avoid maintaining extra copies if possible
There was a problem hiding this comment.
I have no idea. I wasn't able to find a concrete guide on what to include in here.
This is probably something we'll have to play around with and see over the coming weeks/ months.
GEMINI.md
Outdated
|
|
||
| ## 5. Dependency Management | ||
|
|
||
| - Try not to bump any dependency version unless there is a known CVE (security or vulnerability issue) |
There was a problem hiding this comment.
I think there are three main reasons to bump dependency versions
- CVE
- Critical bug fixes
- Required new features
There was a problem hiding this comment.
Adding the first two to the file. I think required new features may be a bit too vague. I can play around with the wording.
| * If they are in `other modules(ast, model, writer etc.)`, you _must_ add traditional unit tests, you _may_ add golden unit tests to easily see the changes. | ||
| - If the changes are in both `gax` and `gapic-generator-java`, you _must_ add all test layers, including traditional unit tests, golden unit tests and showcase integration tests. | ||
|
|
||
| ### 4.2. Running Unit Tests |
There was a problem hiding this comment.
Per run-gemini-cli, gemini.md is useful for "defining coding conventions, architectural patterns, or other guidelines the model should follow for a given repository".
Do we consider "the knowledge of how to run tests" beneficial to code reviews? I don't think it hurts either but I'm not sure there is a use case for it.
There was a problem hiding this comment.
Do we consider "the knowledge of how to run tests" beneficial to code reviews?
Not for code reviews. This is more for generating code and to give gemini cli the context to try and generate the relevant test types. I'm not sure how well this will work (and we can add more or remove complete), but hopefully as we give better prompts and more context, gemini would be able to figure out which types of tests we want.
We do an non-traditional way of testing (comparing with golden tests) which maybe gemini can try and pick up on
There was a problem hiding this comment.
This is more for generating code and to give gemini cli the context to try and generate the relevant test types
SG. This would be great if it works out!
|
|
Attempt to generate a `GEMINI.md` file from the different README files located throughout the repo. This is intended to be a first draft and new information and entries can be added and iterated upon.
Attempt to generate a
GEMINI.mdfile from the different README files located throughout the repo.This is intended to be a first draft and new information and entries can be added and iterated upon.