chore: migrate from not(in(collection)) to e -> !collection.contains(e).#3826
Merged
blakeli0 merged 5 commits intogoogleapis:mainfrom Jun 25, 2025
Merged
chore: migrate from not(in(collection)) to e -> !collection.contains(e).#3826blakeli0 merged 5 commits intogoogleapis:mainfrom
not(in(collection)) to e -> !collection.contains(e).#3826blakeli0 merged 5 commits intogoogleapis:mainfrom
Conversation
…ns(e)`. Guava's functional types have been obsoleted by the JDK's functional types. (This reflects a change we are making throughout Google's internal source code.)
Contributor
|
Hi @eamonnmcmanus, thanks for contributing! Is there an internal issue we can understand more about the background? |
Contributor
Author
Yes, http://b/419373312. I or @kluever can supply more background if needed. |
Contributor
Thanks! I know there are Javadoc to discourage people from using them already, but are they going to be deprecated as well so that it easily reminds us to not use them in the future? |
Contributor
|
/gcbrun |
Contributor
|
/gcbrun |
blakeli0
approved these changes
Jun 25, 2025
lqiu96
pushed a commit
that referenced
this pull request
Aug 21, 2025
…ns(e)`. (#3826) Guava's functional types have been obsoleted by the JDK's functional types. (This reflects a change we are making throughout Google's internal source code.) b/419373312
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guava's functional types have been obsoleted by the JDK's functional types.
(This reflects a change we are making throughout Google's internal source code.)