Skip to content

chore: copy and update PROPERTIES using widely supported syntax#1779

Merged
burkedavison merged 1 commit intomainfrom
bazel-python-dict-copy
Jun 16, 2023
Merged

chore: copy and update PROPERTIES using widely supported syntax#1779
burkedavison merged 1 commit intomainfrom
bazel-python-dict-copy

Conversation

@burkedavison
Copy link
Copy Markdown
Member

@burkedavison burkedavison commented Jun 16, 2023

The dict | dict syntax is only supported in Python 3.9+ which is not available in all test environments.

This PR uses a syntax that is supported more widely.

@burkedavison burkedavison requested a review from a team June 16, 2023 17:49
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jun 16, 2023
blakeli0
blakeli0 approved these changes Jun 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For my own curiosity, what testing environments do not have Python 3.9?

@burkedavison
Copy link
Copy Markdown
Member Author

burkedavison commented Jun 16, 2023

LGTM. For my own curiosity, what testing environments do not have Python 3.9?

Discussed offline

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 16, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 16, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@burkedavison burkedavison merged commit a8f7999 into main Jun 16, 2023
@burkedavison burkedavison deleted the bazel-python-dict-copy branch June 16, 2023 18:06
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 16, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@burkedavison @blakeli0