Skip to content

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Mar 30, 2023

Thank you for opening a Pull Request! For general contributing guidelines, please refer to contributing guide

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Part of #1439☕️

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 30, 2023
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

burkedavison
burkedavison previously approved these changes Mar 30, 2023
@lqiu96 lqiu96 mentioned this pull request Mar 31, 2023
27 tasks
@lqiu96 lqiu96 marked this pull request as ready for review March 31, 2023 15:49
@lqiu96 lqiu96 requested a review from a team as a code owner March 31, 2023 15:49
@lqiu96 lqiu96 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 31, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 31, 2023
@lqiu96
Copy link
Member Author

lqiu96 commented Mar 31, 2023

Draft PR

Thanks for the review! I forgot to change it haha

@lqiu96 lqiu96 merged commit 8ec304a into main Mar 31, 2023
@lqiu96 lqiu96 deleted the main-showcase_serversidestreaming branch March 31, 2023 21:43
JoeWang1127 pushed a commit that referenced this pull request Apr 11, 2023
…#1588) (#809)

* chore: pin versions of dependencies for compatibility with Python 3.6

* fix path of requirements file in synthtool
Source-Link: googleapis/synthtool@69cdb47
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6566dc8226f20993af18e5a4e7a2b1ba85a292b02dedb6a1634cf10e1b418fa5
JoeWang1127 pushed a commit that referenced this pull request Apr 11, 2023
…#1588) (#932)

* chore: pin versions of dependencies for compatibility with Python 3.6

* fix path of requirements file in synthtool
Source-Link: googleapis/synthtool@69cdb47
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6566dc8226f20993af18e5a4e7a2b1ba85a292b02dedb6a1634cf10e1b418fa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants