-
Notifications
You must be signed in to change notification settings - Fork 69
feat(Spring CodeGen): Add customized spring composer for package info #1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…config-package-info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments below, and just a thought (this could totally be a separate pr if we want it):
You probably started out from ClientLibraryPackageInfoComposer.java for SpringPackageInfoComposer.java and cleaned out irrelevant contents.
What if we keep the descriptions for each service like in here, remove the samples, and at the bottom, add a sample to use along the lines of:
"You can inject auto-configured service bean to your Spring Boot application with annotation based configuration @Autowired [serviceBean] or Constructor Injection "
src/main/java/com/google/api/generator/spring/composer/SpringPackageInfoComposer.java
Outdated
Show resolved
Hide resolved
@zhumin8 Ah I think that would be helpful! One concern here might be that A couple of possible approaches here come to mind, in order of estimated effort. Let me know if you have any preferences or suggestions?
|
|
I am inclined to option 3. |
Sounds good! |
zhumin8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Kudos, SonarCloud Quality Gate passed! |
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>








In this PR:
SpringPackageInfoComposer.javato generatepackage-info.java, similar to ClientLibraryPackageInfoComposer.java but customized for spring.SpringWriter.java, remove generation ofgapic_metadata.jsonfor spring libraries.Todos:
SpringComposerTestto include this fileUtilsafter fix(Spring CodeGen): Update and move naming-related logic into utils #1061 is merged