fix(Spring CodeGen): Use service-specific CredentialsProvider in annotation #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
zhumin8
approved these changes
Oct 5, 2022
| CaseFormat.UPPER_CAMEL.to(CaseFormat.LOWER_CAMEL, service.name()) + "Client"; | ||
|
|
||
| String credentialsProviderName = | ||
| CaseFormat.UPPER_CAMEL.to(CaseFormat.LOWER_CAMEL, service.name()) + "Credentials"; |
Contributor
There was a problem hiding this comment.
nit: might worth to extract these two names and pass in as parameters? This way, future changes to the names won't cause a mismatch between bean name and qualifier.
Contributor
Author
There was a problem hiding this comment.
Makes sense! Just pushed a new commit to switch some method names into parameters - is this aligned with what you were thinking of?
|
Kudos, SonarCloud Quality Gate passed! |
zhumin8
approved these changes
Oct 7, 2022
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
) * build(deps): bump certifi from 2022.9.24 to 2022.12.7 in /.kokoro Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.9.24 to 2022.12.7. - [Release notes](https://github.com/certifi/python-certifi/releases) - [Commits](certifi/python-certifi@2022.09.24...2022.12.07) --- updated-dependencies: - dependency-name: certifi dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a follow-up on
Qualifierannotations added: #1045 (comment)googleCredentialsto[serviceName]Credentialsin both qualifier annotation and generated method definition.