-
Notifications
You must be signed in to change notification settings - Fork 69
fix(Spring CodeGen): Add Spring dependencies to build files and use static types instead of vapor references #1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
conflicts and made updates to satisfy tests.
…c-gen-java_gapic_spring.
emmileaf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay concrete references! 🎉
Just a couple of small comments added. It looks like some changes here might also conflict with #1091 - I'll update the refactoring approach there if this PR is merged first.
|
Kudos, SonarCloud Quality Gate passed! |
diegomarquezp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - great!
To account for changes in googleapis/sdk-platform-java#1046, Spring related dependencies needs to be added to [WORKSPACE](https://github.com/googleapis/googleapis/blob/38e8b447d173909d3b2fe8fdc3e6cbb3c85442fd/WORKSPACE#L239-L245).








Adding Spring related dependencies to build files and use static types instead of vapor references.
Benefit of this change:
One caveat is that because
gapic-generator-javais brought intogoogleapisashttp_archivecode addition togoogleapisis also needed to include these libraries. Add below code snippet to WORKSPACE:Updates:
Pending task on
spring-cloud-gcpside:download-repos.shto add Spring dependencies to WORKSPACE as shown above. (fix(codegen): add logic to add spring deps to googleapis/WORKSPACE GoogleCloudPlatform/spring-cloud-gcp#1349)