docs(storage): add documentation for blob and bucket name property#89
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
frankyn
left a comment
There was a problem hiding this comment.
Thanks, I have two nits.
| """ | ||
| return self._name | ||
|
|
||
| @name.setter |
There was a problem hiding this comment.
Recommend removing setter.
There was a problem hiding this comment.
@frankyn If i remove setter then it throws an error like AttributeError: can't set attribute
There was a problem hiding this comment.
Is this why you recommended only adding pydocs instead? If so, then let's do that instead.
There was a problem hiding this comment.
@frankyn Yes , that's why i recommend doc static doc string. i will update the PR. Thanks.
| return self._name | ||
|
|
||
| @name.setter | ||
| def name(self, value): |
fa16c0f to
4fe3494
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
| self._default_object_acl = DefaultObjectACL(self) | ||
| self._label_removals = set() | ||
| self._user_project = user_project | ||
| self._name = name |
|
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
1 similar comment
|
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Fixes #82