Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

samples: delete unspecified sample#671

Merged
shaffeeullah merged 3 commits into
googleapis:mainfrom
shaffeeullah:shaffeeullah/deleteUnspecifiedSample
Dec 16, 2021
Merged

samples: delete unspecified sample#671
shaffeeullah merged 3 commits into
googleapis:mainfrom
shaffeeullah:shaffeeullah/deleteUnspecifiedSample

Conversation

@shaffeeullah

Copy link
Copy Markdown
Contributor

No description provided.

@shaffeeullah shaffeeullah requested a review from a team December 16, 2021 17:56
@shaffeeullah shaffeeullah requested a review from a team as a code owner December 16, 2021 17:56
@shaffeeullah shaffeeullah requested review from a team and engelke December 16, 2021 17:56
@snippet-bot

snippet-bot Bot commented Dec 16, 2021

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Dec 16, 2021
@shaffeeullah shaffeeullah requested a review from cojenco December 16, 2021 17:56
@cojenco

cojenco commented Dec 16, 2021

Copy link
Copy Markdown
Contributor

@shaffeeullah Could you help update the samples/README, specifically delete lines 140 and 980-988, thanks!!

@shaffeeullah

Copy link
Copy Markdown
Contributor Author

@cojenco updated! sorry I always forget about the README in python. node.js has a bot that does this stuff for us and ive gotten super used to it

@cojenco cojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@shaffeeullah shaffeeullah merged commit 0e1a0ff into googleapis:main Dec 16, 2021
@shaffeeullah shaffeeullah deleted the shaffeeullah/deleteUnspecifiedSample branch December 16, 2021 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants