Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

tests: speed up retry conformance tests#655

Merged
cojenco merged 6 commits into
googleapis:mainfrom
cojenco:tune-conftest
Dec 10, 2021
Merged

tests: speed up retry conformance tests#655
cojenco merged 6 commits into
googleapis:mainfrom
cojenco:tune-conftest

Conversation

@cojenco

@cojenco cojenco commented Nov 19, 2021

Copy link
Copy Markdown
Contributor
  • Speed up retry conf tests to run in parallel with pytest plugin
  • Update readme file

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2021
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/python-storage API. label Nov 19, 2021
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 19, 2021
@cojenco cojenco marked this pull request as ready for review November 19, 2021 22:05
@cojenco cojenco requested review from a team November 19, 2021 22:05
Comment thread noxfile.py Outdated
session.run("py.test", "--quiet", conformance_test_path, *session.posargs)
session.run(
"py.test", "-n", "auto", "--quiet", conformance_test_path, *session.posargs
)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be a better DX to inject the "-n", "auto" into the command line only if session.posargs is empty: that way, the user could chose to e.g. restrict the number of cores available, or even distribute the tests across multiple hosts.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tseaver good idea! I've updated the noxfile. PTAL, thanks!

@cojenco cojenco merged commit ee41b3f into googleapis:main Dec 10, 2021
@cojenco cojenco deleted the tune-conftest branch November 16, 2023 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants