Skip to content

tests: harden 'test_bucket_w_retention_period' vs EC #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 1 commit into from
Aug 24, 2021
Merged

tests: harden 'test_bucket_w_retention_period' vs EC #552

tseaver merged 1 commit into from
Aug 24, 2021

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 23, 2021

Closes #551.

@tseaver tseaver requested review from a team and cojenco August 23, 2021 19:47
@tseaver tseaver requested a review from a team as a code owner August 23, 2021 19:47
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Aug 23, 2021
cojenco
cojenco approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tseaver tseaver merged commit a339643 into master Aug 24, 2021
@tseaver tseaver deleted the 551-tests-harden-bucket-w-retention-systest branch August 24, 2021 05:25
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
tests: harden 'test_bucket_w_retention_period' vs EC (googleapis#552)
8adcc0c 
Closes googleapis#551.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
tests: harden 'test_bucket_w_retention_period' vs EC (googleapis#552)
e2f6427 
Closes googleapis#551.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cojenco cojenco cojenco approved these changes

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_bucket_w_retention_period flakes due to EC

2 participants

@tseaver @cojenco