Skip to content

tests: use 120 sec timeout for 'blob.delete' during teardown #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 2 commits into from
Jul 22, 2021
Merged

tests: use 120 sec timeout for 'blob.delete' during teardown #518

tseaver merged 2 commits into from
Jul 22, 2021

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 20, 2021

Closes #517

@tseaver tseaver requested review from a team, andrewsg, cojenco, frankyn, tritone and tswast July 20, 2021 22:08
@tseaver tseaver requested a review from a team as a code owner July 20, 2021 22:08
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jul 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2021
cojenco
cojenco approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tseaver tseaver merged commit 24ea536 into master Jul 22, 2021
@tseaver tseaver deleted the 517-unflake-blobs_to_delete-teardown branch July 22, 2021 14:16
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
tests: use 120 sec timeout for 'blob.delete' during teardown (googlea…
e6fca0f 
…pis#518)

Closes googleapis#517
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
tests: use 120 sec timeout for 'blob.delete' during teardown (googlea…
c30c37d 
…pis#518)

Closes googleapis#517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cojenco cojenco cojenco approved these changes

@tswast tswast Awaiting requested review from tswast

@andrewsg andrewsg Awaiting requested review from andrewsg

@frankyn frankyn Awaiting requested review from frankyn

@tritone tritone Awaiting requested review from tritone

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Teardown of blobs_to_delete fixture flakes with TimeoutError.

2 participants

@tseaver @cojenco