Skip to content

tests: harden 'test_bucket_w_default_event_based_hold' #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 2 commits into from
Jun 21, 2021
Merged

tests: harden 'test_bucket_w_default_event_based_hold' #468

tseaver merged 2 commits into from
Jun 21, 2021

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 14, 2021

Reload blob w/ spurious EBH.

Closes #435.

@tseaver tseaver requested review from a team, andrewsg and frankyn June 14, 2021 16:48
@tseaver tseaver requested a review from a team as a code owner June 14, 2021 16:48
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jun 14, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2021
@tseaver tseaver requested a review from chrisrossi June 14, 2021 20:03
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2021
chrisrossi
chrisrossi approved these changes Jun 21, 2021
View reviewed changes
Copy link

@chrisrossi chrisrossi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I wasn't really familiar with the full bag of tricks available in test_utils when working on NDB and ended up reinventing the wheel with some of the retry for eventual consistency stuff.

@tseaver
tests: harden 'test_bucket_w_default_event_based_hold'
618f480 
Reload blob w/ spurious EBH.

Closes #435.
@tseaver tseaver force-pushed the 435-harden-default-event-based-hold-systest branch from 68f67c8 to 618f480 Compare June 21, 2021 15:59
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Jun 21, 2021
@tseaver tseaver removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 21, 2021
@tseaver tseaver merged commit 3b06f9e into master Jun 21, 2021
@tseaver tseaver deleted the 435-harden-default-event-based-hold-systest branch June 21, 2021 16:22
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
tests: harden 'test_bucket_w_default_event_based_hold' (googleapis#468)
0c7d27f 
Reload blob w/ spurious EBH.

Closes googleapis#435.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
tests: harden 'test_bucket_w_default_event_based_hold' (googleapis#468)
9a622c9 
Reload blob w/ spurious EBH.

Closes googleapis#435.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsg andrewsg Awaiting requested review from andrewsg

@frankyn frankyn Awaiting requested review from frankyn

1 more reviewer

@chrisrossi chrisrossi chrisrossi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'test_bucket_w_default_event_based_hold' systest is flaky

3 participants

@tseaver @chrisrossi @yoshi-kokoro