Skip to content

fix: address incorrect usage of request preconditions #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frankyn merged 1 commit into from
Jan 28, 2021
Merged

fix: address incorrect usage of request preconditions #366

frankyn merged 1 commit into from
Jan 28, 2021

Conversation

@frankyn
Copy link
Contributor

@frankyn frankyn commented Jan 26, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #364 🦕

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jan 26, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 26, 2021
@frankyn frankyn requested a review from andrewsg January 27, 2021 00:01
@frankyn frankyn marked this pull request as ready for review January 27, 2021 00:01
@frankyn frankyn requested a review from a team January 27, 2021 00:01
@frankyn frankyn merged commit 321658c into master Jan 28, 2021
@frankyn frankyn deleted the fix-364 branch January 28, 2021 22:43
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@frankyn @cojenco
fix: address incorrect usage of request preconditions (googleapis#366)
4576b83
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@frankyn @cojenco
fix: address incorrect usage of request preconditions (googleapis#366)
98a3b4b
@release-please release-please bot mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsg andrewsg andrewsg approved these changes

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rename_blob() with if_generation_match fails on DELETE

2 participants

@frankyn @andrewsg