This repository was archived by the owner on Mar 31, 2026. It is now read-only.
testing: fix / skip systests broken by dependency releases#227
Merged
Conversation
See #226. This PR doesn't *fix* the issue, because the KMS breakage exists: it just skips the KMS systests under Python3, until we have dropped support for Python2.
busunkim96
approved these changes
Aug 4, 2020
busunkim96
left a comment
Contributor
There was a problem hiding this comment.
Is it possible to pin to an older version of KMS instead of skipping?
Contributor
Author
|
@busunkim96 OK, that works: #232 |
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…s#227) See googleapis#226. This PR doesn't *fix* the issue, because the KMS breakage still exists: it just skips the KMS systests under Python3, until we have dropped support for Python2.
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…s#227) See googleapis#226. This PR doesn't *fix* the issue, because the KMS breakage still exists: it just skips the KMS systests under Python3, until we have dropped support for Python2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #226. This PR doesn't fix the issue, because the KMS breakage exists: it just skips the KMS systests under Python3, until we have dropped support for Python2.