feat: instrument metadata ops with OTel tracing (#2) #1267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsg
reviewed
May 8, 2024
Contributor
andrewsg
left a comment
There was a problem hiding this comment.
One question. Otherwise LGTM. Great text copy in the README.
andrewsg
approved these changes
May 9, 2024
cojenco
added a commit
that referenced
this pull request
Jun 26, 2024
* feat: introduce OpenTelemetry Tracing decorators (#1257) * feat: introduce OpenTelemetry Tracing decorators * update test coverage * add tests, update fixture * update noxfile, extras; remove print * update unit test * review comments * feat: instrument metadata ops with OTel tracing (#2) (#1267) * feat: instrument metadata ops with Otel tracing * update README plus test * update decorator name per review session * fix typo in readme * feat: OTel tracing media ops initial instrumentation (#1280) * feat: OTel tracing media ops initial instrumentation * use download class name as span name * avoid asserting filtered warnings from otel per open-telemetry/opentelemetry-python#3164 * add copyright and preview note * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part 2
create_trace_spanper review sessionFixes internal b/330755934