Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

samples: replace deprecated method#1211

Merged
cojenco merged 3 commits intogoogleapis:mainfrom
cojenco:sample-replace
Feb 28, 2024
Merged

samples: replace deprecated method#1211
cojenco merged 3 commits intogoogleapis:mainfrom
cojenco:sample-replace

Conversation

@cojenco
Copy link
Copy Markdown
Contributor

@cojenco cojenco commented Jan 18, 2024 •
edited
Loading

Replace deprecated method download_as_string in samples; related to internal bug b/320588834

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Jan 18, 2024
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2024
@cojenco cojenco marked this pull request as ready for review January 18, 2024 23:33
@cojenco cojenco requested a review from a team as a code owner January 18, 2024 23:33
@cojenco cojenco requested review from a team and iennae January 18, 2024 23:33
andrewsg
andrewsg suggested changes Feb 15, 2024
View reviewed changes
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Feb 23, 2024
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2024
@cojenco cojenco requested a review from andrewsg February 28, 2024 19:24
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@cojenco cojenco merged commit 0b8f5b0 into googleapis:main Feb 28, 2024
@cojenco cojenco deleted the sample-replace branch October 30, 2024 00:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@iennae iennae Awaiting requested review from iennae iennae is a code owner automatically assigned from googleapis/python-samples-reviewers

1 more reviewer

@andrewsg andrewsg andrewsg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cojenco @andrewsg