feat: Proto Columns Feature#909
Merged
surbhigarg92 merged 17 commits intogoogleapis:proto-column-enhancement-alphafrom Mar 27, 2023
Merged
feat: Proto Columns Feature#909surbhigarg92 merged 17 commits intogoogleapis:proto-column-enhancement-alphafrom
surbhigarg92 merged 17 commits intogoogleapis:proto-column-enhancement-alphafrom
Conversation
asthamohta
reviewed
Mar 14, 2023
asthamohta
reviewed
Mar 14, 2023
asthamohta
reviewed
Mar 14, 2023
asthamohta
reviewed
Mar 14, 2023
asthamohta
reviewed
Mar 14, 2023
asthamohta
reviewed
Mar 14, 2023
asthamohta
reviewed
Mar 14, 2023
asthamohta
reviewed
Mar 14, 2023
asthamohta
reviewed
Mar 14, 2023
asthamohta
reviewed
Mar 14, 2023
asthamohta
approved these changes
Mar 20, 2023
|
Here is the summary of changes. You are about to add 7 region tags.
This comment is generated by snippet-bot.
|
gauravpurohit06
suggested changes
Mar 23, 2023
gauravpurohit06
suggested changes
Mar 24, 2023
gauravpurohit06
approved these changes
Mar 27, 2023
Contributor
gauravpurohit06
left a comment
There was a problem hiding this comment.
LGTM, As discussed offline just remove the tags from the additional samples which we don't want to publish.
harshachinta
added a commit
that referenced
this pull request
May 16, 2024
* feat: Proto Columns Feature (#909) * feat: adding proto autogenerated code changes for proto column feature * feat: add implementation for Proto columns DDL * feat: add implementation for Proto columns DML * feat: add implementation for Proto columns DQL * feat: add NoneType check during Proto deserialization * feat: add code changes for Proto DDL support * feat: add required proto files to execute samples and tests * feat: add sample snippets for Proto columns DDL * feat: add tests for proto columns ddl, dml, dql snippets * feat: code refactoring * feat: remove staging endpoint from snippets.py * feat: comment refactor * feat: add license file * feat: update proto column data in insertion sample * feat: move column_info argument to the end to avoid breaking code * feat: Proto column feature tests and samples (#921) * feat: add integration tests for Proto Columns * feat: add unit tests for Proto Columns * feat: update tests to add column_info argument at end * feat: remove deepcopy during deserialization of proto message * feat: tests refactoring * feat: integration tests refactoring * feat: samples and sample tests refactoring * feat: lint tests folder * feat:lint samples directory * feat: stop running emulator with proto ddl commands * feat: close the file after reading * feat: update protobuf version lower bound to >3.20 to check proto message compatibility * feat: update setup for snippets_tests.py file * feat: add integration tests * feat: remove duplicate integration tests * feat: add proto_descriptor parameter to required tests * feat: add compatibility tests between Proto message, Bytes and Proto Enum, Int64 * feat: add index tests for proto columns * feat: replace duplicates with sample data * feat: update protobuf lower bound version in setup.py file to add support for proto messages and enum * feat: lint fixes * feat: lint fix * feat: tests refactoring * feat: change comment from dml to dql for read * feat: tests refactoring for update db operation * feat: rever autogenerated code * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: fix code * fix: fix code * fix(spanner): fix code * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix(spanner): skip emulator due to b/338557401 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix(spanner): remove samples * fix(spanner): update coverage * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore(spanner): update coverage * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix(spanner): add samples and update proto schema * fix(spanner): update samples database and emulator DDL * fix(spanner): update admin test to use autogenerated interfaces * fix(spanner): comment refactoring --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds code changes for Proto Columns feature support in Python Client along with sample snippets.