Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

test: deflake system test#866

Merged
asthamohta merged 6 commits intomainfrom
deflake-system-test
Dec 13, 2022
Merged

test: deflake system test#866
asthamohta merged 6 commits intomainfrom
deflake-system-test

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Dec 9, 2022

Add try/finally around table creation in system tests to ensure cleanup when there is a failure.

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. labels Dec 9, 2022
@parthea parthea force-pushed the deflake-system-test branch from 2023776 to b682549 Compare December 12, 2022 14:34
@parthea parthea marked this pull request as ready for review December 12, 2022 14:38
@parthea parthea requested a review from a team as a code owner December 12, 2022 14:38
@parthea parthea requested a review from a team December 12, 2022 14:38
@parthea
Copy link
Copy Markdown
Contributor Author

parthea commented Dec 12, 2022

The failures appear to be unrelated. @asthamohta Please could you take a look?

@asthamohta asthamohta enabled auto-merge (squash) December 13, 2022 15:20
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 13, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 13, 2022
@asthamohta asthamohta merged commit 234b21e into main Dec 13, 2022
@asthamohta asthamohta deleted the deflake-system-test branch December 13, 2022 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants