Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

test: remove unneeded system test skip when using emulator#80

Merged
larkee merged 1 commit intogoogleapis:masterfrom
larkee:spanner-em-host
May 13, 2020
Merged

test: remove unneeded system test skip when using emulator#80
larkee merged 1 commit intogoogleapis:masterfrom
larkee:spanner-em-host

Conversation

@larkee
Copy link
Copy Markdown
Contributor

@larkee larkee commented May 11, 2020

The functionality in test_partition_query is supported by the emulator. We should not be skipping it.

@larkee larkee requested a review from hengfengli May 11, 2020 00:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 11, 2020
hengfengli
hengfengli approved these changes May 11, 2020
View reviewed changes
Copy link
Copy Markdown

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When did they start supporting partitioned queries?

@larkee
Copy link
Copy Markdown
Contributor Author

larkee commented May 11, 2020

LGTM. When did they start supporting partitioned queries?

Unclear. However, the test does not give an UNIMPLEMENTED error. It instead give the following error:

E       AssertionError: Lists differ: [[1, 'First000000001', 'Last000000039', 'te[2782 chars]om']] != [[0, 'First000000000', 'Last000000040', 'te[2782 chars]om']]
E       
E       First differing element 0:
E       [1, 'First000000001', 'Last000000039', 'test-000000001@example.com']
E       [0, 'First000000000', 'Last000000040', 'test-000000000@example.com']
E       
E       Diff is 4732 characters long. Set self.maxDiff to None to see it.

So the functionality is implemented.

@larkee larkee added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 11, 2020
@larkee
Copy link
Copy Markdown
Contributor Author

larkee commented May 13, 2020

The above test failure is related to results order. There is no guarantee of order without using ORDER BY which is not supported by partitioned queries. I have a fix which I will make as a separate PR.

@larkee larkee merged commit b8c1a67 into googleapis:master May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@hengfengli hengfengli hengfengli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@larkee @hengfengli @googlebot