Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: remove 'include_protos' kwarg that causes synth to fail#72

Closed
larkee wants to merge 1 commit intogoogleapis:masterfrom
larkee:fix-synth
Closed

fix: remove 'include_protos' kwarg that causes synth to fail#72
larkee wants to merge 1 commit intogoogleapis:masterfrom
larkee:fix-synth

Conversation

@larkee
Copy link
Copy Markdown
Contributor

@larkee larkee commented Apr 29, 2020

#64 caused a synth failure due to the bazel generator not supporting the include_protos kwargs.

Removing this kwarg allows the synth to complete successfully.

@larkee larkee requested a review from busunkim96 April 29, 2020 04:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2020
@busunkim96
Copy link
Copy Markdown
Contributor

@larkee Could you try upgrading the synthtool version? include_protos was added fairly recently to GAPICBazel

python3 -m pip install --user --upgrade git+https://github.com/googleapis/synthtool.git

@larkee
Copy link
Copy Markdown
Contributor Author

larkee commented Apr 29, 2020

@larkee Could you try upgrading the synthtool version? include_protos was added fairly recently to GAPICBazel

python3 -m pip install --user --upgrade git+https://github.com/googleapis/synthtool.git

Ahhh. I tried to do an upgrade through pip but I didn't think to use the git link. It works now 👍

@larkee larkee closed this Apr 29, 2020
@larkee larkee deleted the fix-synth branch April 29, 2020 22:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants