Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

chore: Migrate python-spanner synth.py from artman to bazel#64

Merged
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:masterfrom
vam-google:master
Apr 28, 2020
Merged

chore: Migrate python-spanner synth.py from artman to bazel#64
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:masterfrom
vam-google:master

Conversation

@vam-google
Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 21, 2020
@vam-google
Copy link
Copy Markdown
Contributor Author

@busunkim96 PTAL

@busunkim96
Copy link
Copy Markdown
Contributor

@larkee This changes how the generator is called, but it should not change the result of the generation. Let me know if something is off in the next autosynth PR.

@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 28, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 5d8935d into googleapis:master Apr 28, 2020
@larkee
Copy link
Copy Markdown
Contributor

larkee commented Apr 29, 2020

Running the synthtool via python -m synthtool without any changes gives the following error:

TypeError: _generate_code() got an unexpected keyword argument 'include_protos'

Removing the include_protos kwarg allows the synthtool to complete successfully. This fix is in #72

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants