Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

docs: re-pin sphinx version#70

Merged
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:masterfrom
larkee:pin-sphnix-ver
Apr 29, 2020
Merged

docs: re-pin sphinx version#70
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:masterfrom
larkee:pin-sphnix-ver

Conversation

@larkee
Copy link
Copy Markdown
Contributor

@larkee larkee commented Apr 28, 2020

Reopens #50

Unfortunately, synthtool has pinned to sphinx<3.0.0 which means any code regen via synth will cause docs to fail. Until it is updated to support it, we also need to pin to sphinx<3.0.0.

@larkee larkee requested a review from hengfengli April 28, 2020 03:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 28, 2020
Copy link
Copy Markdown

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@larkee larkee added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4d54a5c into googleapis:master Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants