tests: add backup integration tests#69
Conversation
skuruppu
left a comment
There was a problem hiding this comment.
Looks good. But as we've been finding for other languages, you'll find that these tests will often timeout during the backup creation or restore part. So it would be good to reduce the number of create and restore calls. E.g. I think I never added a restore to different instance test in Node.js.
You can also save time by not waiting for the optimize. You can do:
- Wait for restore to complete.
- Delete restored database.
- Delete backup.
It's faster this way and you don't get a FAILED_PRECONDITION error when you're trying to delete the backup.
I haven't run into any timeouts recently so I'm okay with keeping the different instance restore.
Done 👍 This also fixed a flaky test! |
No description provided.