Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

test: delete referencing databases before backups#581

Merged
larkee merged 4 commits intomainfrom
fix-cleanup
Oct 4, 2021
Merged

test: delete referencing databases before backups#581
larkee merged 4 commits intomainfrom
fix-cleanup

Conversation

@larkee
Copy link
Copy Markdown
Contributor

@larkee larkee commented Sep 17, 2021

Fixes #557
Fixes #573
Fixes #574
Fixes #575
Fixes #576
Fixes #577
Fixes #578
Fixes #579

@larkee larkee requested a review from a team September 17, 2021 04:25
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Sep 17, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2021
hengfengli
hengfengli approved these changes Sep 23, 2021
View reviewed changes
Copy link
Copy Markdown

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@larkee larkee added the automerge Merge the pull request once unit tests and other checks pass. label Sep 23, 2021
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green bot commented Sep 23, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 23, 2021
@thiagotnunes thiagotnunes self-requested a review September 26, 2021 10:55
@larkee larkee merged commit 0404a33 into main Oct 4, 2021
@larkee larkee deleted the fix-cleanup branch October 4, 2021 23:31
asthamohta pushed a commit to asthamohta/python-spanner that referenced this pull request Dec 24, 2021
@larkee @asthamohta
test: delete referencing databases before backups (googleapis#581)
f77e72b 
* test: delete referencing databases before backups

* fix: use proto value

Co-authored-by: larkee <larkee@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@thiagotnunes thiagotnunes thiagotnunes approved these changes

@hengfengli hengfengli hengfengli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

4 participants

@larkee @thiagotnunes @hengfengli @yoshi-kokoro