Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

test: use assertIsInstance where possible#57

Merged
larkee merged 2 commits intogoogleapis:masterfrom
larkee:update-asserts
Apr 17, 2020
Merged

test: use assertIsInstance where possible#57
larkee merged 2 commits intogoogleapis:masterfrom
larkee:update-asserts

Conversation

@larkee
Copy link
Copy Markdown
Contributor

@larkee larkee commented Apr 16, 2020

Using the self.assertIsInstance(..., ...) method will give more detailed error information than self.assertTrue(isinstance(..., ...))

@larkee larkee requested a review from hengfengli April 16, 2020 23:39
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 16, 2020
@larkee larkee changed the title test: use testIsInstance where possible test: use assertIsInstance where possible Apr 17, 2020
hengfengli
hengfengli approved these changes Apr 17, 2020
View reviewed changes
Copy link
Copy Markdown

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@larkee larkee merged commit df199f7 into googleapis:master Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@hengfengli hengfengli hengfengli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@larkee @hengfengli @googlebot